Pages: 1 2 3 4 5 6 7 [8] 9 10 11 12 13 14 15 16 .. 16 :: one page |
|
Author |
Thread Statistics | Show CCP posts - 0 post(s) |
Oreamnos Amric
Z3R0 RETURN MINING INC. Illusion of Solitude
53
|
Posted - 2014.03.15 14:20:00 -
[211] - Quote
I'm running an older version of TEA and made the following change to fix the issue with the changed attributes
In file 'Sources/TEAC.php' I changed line 573 and 1006 from
$char = explode('" />', $char[1], 2);
to
$char = explode('" allianceID="', $char[1], 2);
This seems to have fixed the problem for now but the real fix would be to properly process XML as XML rather than rely on the ordering of CCP's API output.
I haven't looked at the updated version of the code by the OP of this thread. I assume it has the same problem from the comments above this. |
Dark Angel66
ANGELGARD. Red Alliance
1
|
Posted - 2014.03.15 15:06:00 -
[212] - Quote
Oreamnos Amric wrote:I'm running an older version of TEA and made the following change to fix the issue with the changed attributes
In file 'Sources/TEAC.php' I changed line 573 and 1006 from
$char = explode('" />', $char[1], 2);
to
$char = explode('" allianceID="', $char[1], 2);
This seems to have fixed the problem for now but the real fix would be to properly process XML as XML rather than rely on the ordering of CCP's API output.
I haven't looked at the updated version of the code by the OP of this thread. I assume it has the same problem from the comments above this.
thx! |
Shin Chogan
Blueprint Haus Get Off My Lawn
55
|
Posted - 2014.03.15 15:08:00 -
[213] - Quote
Ah Ha ... nice find Demitrios. I looked too late in the process sequence ... I was rushing to take a look before heading to the Opticians and didn't track back far enough.
I suppose you could add in some code to truncate after the first space and use that for corpID but as you say we shouldn't have to coz it is just broken xml.
Oreamnos Amric - the new versions do exactly what you say ... they put the returned XML in a SimpleXML object and use that for the parsing ... much nicer than the older way of doing it but it means that if the XML is invalid there are problems which is exactly what we are seeing here. |
Demitrios
Di-Tron Heavy Industries Fatal Ascension
16
|
Posted - 2014.03.15 15:25:00 -
[214] - Quote
I just looked at the cache, showed me what commands were being sent to the api, just needed to figure out where it was getting that extra info to send.
The dev said that he added extra into to the api result, but looking at http://wiki.eve-id.net/APIv2_Account_Characters_XML seems to suggest that information was there previously.
In any case, with or without the extra info, it would work fine if the extra data had columns put in.
At least it will be fixed in the next few days, and the change to the test api server shows the fix in action.
http://api.testeveonline.com/account/Characters.xml.aspx?keyID=1467486&vCode=vICLFqVcIdY596Q83sFPoYvAsWGWzl6oEnXs1AVorAsX8BqMW4pkxAfu4JQmVjmE |
Oreamnos Amric
Z3R0 RETURN MINING INC. Illusion of Solitude
54
|
Posted - 2014.03.15 15:26:00 -
[215] - Quote
Shin Chogan wrote:Oreamnos Amric - the new versions do exactly what you say ... they put the returned XML in a SimpleXML object and use that for the parsing ... much nicer than the older way of doing it but it means that if the XML is invalid there are problems which is exactly what we are seeing here.
Treating XML as XML you say? Well I'm sold
There isn't a massive amount you can do with malformed XML except behave properly. I'd seen the old TEA remove everyone's access when the API didn't return any information at all. Probably due to the same code as was hit here. With a proper XML parser you at least know if you have received junk data and can behave properly (i.e. do nothing rather than mess up everyone's access). |
Shin Chogan
Blueprint Haus Get Off My Lawn
56
|
Posted - 2014.03.15 15:41:00 -
[216] - Quote
Hmmmmm .... "interesting"
row characterID="xxxxx" characterName="xxxxxxx" corporationID="1000168" corporationName="Federal Navy Academy"
pulled from my tea cache from a cron fetch done at :
currentTime 2014-03-15 15:17:16 /currentTime
looks like they've gone the other way on Tranquility's api server. |
Liez Onerbak
Juggies LLC
0
|
Posted - 2014.03.15 17:51:00 -
[217] - Quote
I'm assuming we just basically need to wait for CCP to fix this? If we change things now it's just going to break again when they change/fix things on their end, right? |
Demitrios
Di-Tron Heavy Industries Fatal Ascension
16
|
Posted - 2014.03.15 18:24:00 -
[218] - Quote
I wouldn't touch a thing, TEA worked fine for the past 4 years with no issues, ignoring the big change to CAK, no reason to change it now when they are going to fix it. |
Dark Sequent
Nisroc Angels The Obsidian Front
0
|
Posted - 2014.03.15 21:09:00 -
[219] - Quote
The latest patch has disrupted the API mode for the forums we are running 1.3.1 r4 any suggestions please |
Cyerus
Eternal Strife
254
|
Posted - 2014.03.16 00:17:00 -
[220] - Quote
Demitrios wrote:I wouldn't touch a thing, TEA worked fine for the past 4 years with no issues, ignoring the big change to CAK, no reason to change it now when they are going to fix it. By "they" you mean the actual TEA developer I hope? If not, you are an idiot and please stfu, and here is why.
Like some posts before you, its clear that the "old" way of parsing xml TEA is using is error prone, as it can easily be broken by even valid xml documents. A proper way would be to use SimpleXML to parse it (and catch it for invalid XML results), and grab the values from the returned object. Even better would be to use PhealNG, as PhealNG uses SimpleXML internally while also providing checks for cache and valid keys (based on requests).
For the last couple of years we (the 3rd party developers, mainly located on Coldfront IRC channel #eve-dev) have been requesting updates to the EVE API, mainly to remove annoyances and limitations because of outdated code. Where most CCPers made only small changes (some good, some bad), we haven't really had any big updates. True, CAKs came out making it easier for people to share api keys, but in the end no big changes were made to the data itself.
Since the introduction of the CAKs CCP started to monitor API errors even more closely. By that, I mean that if you try to get the characterId with a nonexistants characterName, you'd get an error stating that the 'character doesn't exist'. Errors are logged based on IP. If you get too many errors (like if you try to find all characters in EVE), you'll get temp/perm-banned from the EVE API.
This however did not make sense as you had to query some API endpoints to figure out certain information (like killmails and if the character was part of FW), which would return an error. Killmails in particular was an annoying call, as per character you could only get the killmail list once per hour in total (not dependant on IP). So if zKB would query the killmail endpoint, Battleclinic and others would receive an error. Imagine that happening to the thousands of API requests per hour, and yes you can guess it....*poof*...killboards were banned by CCPs strict policy. PrismX saved the day by removing such bans until a new killmail API was built and released, allowing killmails to be checked by multiple killboards.
Things slowed down after this though. We were hoping for more conversation between CCP and 3rd party developers, but unfortunately the API is only considered a side-project by CCP which has to make way for more important stuff. In short, PrismX doesn't have a lot of time to invest on it.
Luckily, FoxFour was able to save the day. Even though the API is not his project, he was able to introduce small tweaks which we've been waiting for for a long time. Most noticeable is the CREST killmail endpoint allowing players to easily post killmails to killboards in a verified way. But also small changes like adding factionId and factionName to most character-based calls so you don't have to generate any errors anymore to figure out if a character is part of FW. Or the new OwnerId call where you can actually see what the ownerType is you are requesting (figure out if Cyerus might a character, corporation or alliance), effectively making CharacterID obsolete.. (more information can be found here).
And yes, you are correct in saying CCP should fix this small bug, and they certainly will. However, I'd like to point out its not their fault for you not helping to test the new changes. Yes, you, the person who has been using TEA for over 4 years without a problem blaming CCP for every small glitch, while you could've set up a test forum pointing to the updated Sisi API server to see if everything would be working correctly..
After all; CCP FoxFour went far and beyond to make those API changes, I guess a small "thank you" is impossible to say.
ps. Vote Fuzzysteve for CSM, as he's the only CSM candidate whom I've seen contribute in the CCP / 3rd party developer scene. |
|
Shin Chogan
Blueprint Haus Get Off My Lawn
56
|
Posted - 2014.03.16 00:31:00 -
[221] - Quote
Cyerus wrote:Demitrios wrote:I wouldn't touch a thing, TEA worked fine for the past 4 years with no issues, ignoring the big change to CAK, no reason to change it now when they are going to fix it. By "they" you mean the actual TEA developer I hope? If not, you are an idiot and please stfu, and here is why.
lol ... they put out invalid XML and I should "fix" it to be honest I'm not sure why the invalid XML isn't being handled in these guy's versions, still not sure what they are all running r5 should handle it but r4 wouldn't work well My version handled it just fine but I does have some not released code. |
Demitrios
Di-Tron Heavy Industries Fatal Ascension
16
|
Posted - 2014.03.16 10:00:00 -
[222] - Quote
Cyerus wrote:Diatribe followed by spam asking people to vote for someone in the CSM election.
1, The version of TEA i use does use simplexml. 2, If you bothered to read the twitter messages that went between me and CCP FoxFour, you would see that while i was annoyed to begin with, he explained what happened, and why the error was allowed to go into a production service without anything being caught in a code review. Which instantly killed any anger I had, as somebody who made the change, was fixing it. 3, I did thank him, mostly due to him fixing the problem within an hour of being made aware of the problem, and partly because we didn't have to wake for weeks for CCP to go through it's usual internal argument of "NOPE! EVERYTHING IS FINE!". |
Zenith Gravit
LionGate Enterprises Care Factor
38
|
Posted - 2014.03.16 19:00:00 -
[223] - Quote
I'm not sure if anyone else has run into this, but I just resolved an issue with my mail queue in SMF not processing because the TEA Cron tasks had all been declared twice. Maybe just a fluke, but hopefully this bit of info saves someone else the headache I just had. |
Yngwiedis
Yngwie J. Malmsteen's Rising Force
6
|
Posted - 2014.03.17 20:02:00 -
[224] - Quote
Hello...
I have version 1.3.1 R2 installed in my forum. I am trying to uninstall that version and install R5, but when i uninstall R2, my forum goes to a white page and is not accessible. I already try 5 times and every time i had to get a forum files backup and upload them again. Can you help me with that problem please ?
Thank you. |
Yveth
Sons of Ivaldi Zero Hour Alliance
1
|
Posted - 2014.03.17 20:35:00 -
[225] - Quote
Yngwiedis wrote:Hello...
I have version 1.3.1 R2 installed in my forum. I am trying to uninstall that version and install R5, but when i uninstall R2, my forum goes to a white page and is not accessible. I already try 5 times and every time i had to get a forum files backup and upload them again. Can you help me with that problem please ?
Thank you.
Download the file index.php from your host, Open it and search: require_once($sourcedir.'/TEA.php');
remove or //require_once($sourcedir.'/TEA.php'); this line and save, upload and refresh.
This should do the trick.
(worked for me) |
Yngwiedis
Yngwie J. Malmsteen's Rising Force
6
|
Posted - 2014.03.17 21:37:00 -
[226] - Quote
Yveth wrote:Yngwiedis wrote:Hello...
I have version 1.3.1 R2 installed in my forum. I am trying to uninstall that version and install R5, but when i uninstall R2, my forum goes to a white page and is not accessible. I already try 5 times and every time i had to get a forum files backup and upload them again. Can you help me with that problem please ?
Thank you. Download the file index.php from your host, Open it and search: require_once($sourcedir.'/TEA.php'); remove or //require_once($sourcedir.'/TEA.php'); this line and save, upload and refresh. This should do the trick. (worked for me)
No luck. Still white screen...
|
Tahnil
Sirius Fleet
44
|
Posted - 2014.03.18 08:43:00 -
[227] - Quote
How did you manage this? Because I seem to have the same problem. |
Demitrios
Di-Tron Heavy Industries Fatal Ascension
16
|
Posted - 2014.03.18 19:35:00 -
[228] - Quote
Just playing with the new version, and for some reason, the mod is allowing people to register without putting any api details in, yet the mod is set to require api details for registration.
It doesn't throw up any errors, you just skip the api details and hit register, and an account is made.
Any ideas, Shin?
Thanks,
Demi |
Eld83
ZERO T0LERANCE RAZOR Alliance
0
|
Posted - 2014.03.19 12:20:00 -
[229] - Quote
They did not fix that API-Call yet, did they? |
Liez Onerbak
Juggies LLC
0
|
Posted - 2014.03.19 14:44:00 -
[230] - Quote
Eld83 wrote:They did not fix that API-Call yet, did they?
Doesn't look like it. Not yet. |
|
Shin Chogan
Blueprint Haus Get Off My Lawn
56
|
Posted - 2014.03.19 20:26:00 -
[231] - Quote
Demitrios wrote:Just playing with the new version, and for some reason, the mod is allowing people to register without putting any api details in, yet the mod is set to require api details for registration.
It doesn't throw up any errors, you just skip the api details and hit register, and an account is made.
Any ideas, Shin?
Thanks,
Demi
Yeah ... I'd missed a test case and screwed up ... https://forums.eveonline.com/default.aspx?g=posts&m=4148939#post4148939 should fix that issue. |
Shin Chogan
Blueprint Haus Get Off My Lawn
56
|
Posted - 2014.03.19 20:36:00 -
[232] - Quote
Tahnil wrote:How did you manage this? Because I seem to have the same problem.
This type of error sounds very much like you've installed other Mods after TEA ...if you look in your apache/what ever webserver you use logs you will probably see a php fatal error ... this should tell you roughly where the problem is. |
Zenith Gravit
LionGate Enterprises Care Factor
38
|
Posted - 2014.03.21 02:47:00 -
[233] - Quote
Currently when people try to register on our forums the "TEA Required Options" fields show twice on the registration page and when someone clicks Get Characters they get the error "API call error while fetching toons: Error Code = 106 for key id = undefined "
Any suggestions? |
Shin Chogan
Blueprint Haus Get Off My Lawn
57
|
Posted - 2014.03.21 19:18:00 -
[234] - Quote
Zenith Gravit wrote:Currently when people try to register on our forums the "TEA Required Options" fields show twice on the registration page and when someone clicks Get Characters they get the error "API call error while fetching toons: Error Code = 106 for key id = undefined "
Any suggestions?
Sounds like you've done an uninstall at some point and then an install of a new version but the uninstall didn't complete correctly. This usually happens when you install other mods after TEA and the uninstall script can't find the bits it needs to remove from an existing file ... you are going to need to clean up your install I'm afraid. |
Jen Moriarty
Love for You Stealth Wear Inc.
41
|
Posted - 2014.03.21 21:01:00 -
[235] - Quote
Hi there,
So I'm seeing a problem similar to the one described here: https://forums.eveonline.com/default.aspx?g=posts&m=3969052#post3969052
where accessing the userservice through a URL does add users to Openfire but the TEA section in SMF does not. Did you ever figure out what caused this? |
Zenith Gravit
LionGate Enterprises Care Factor
38
|
Posted - 2014.03.21 21:39:00 -
[236] - Quote
Shin Chogan wrote:Zenith Gravit wrote:Currently when people try to register on our forums the "TEA Required Options" fields show twice on the registration page and when someone clicks Get Characters they get the error "API call error while fetching toons: Error Code = 106 for key id = undefined "
Any suggestions? Sounds like you've done an uninstall at some point and then an install of a new version but the uninstall didn't complete correctly. This usually happens when you install other mods after TEA and the uninstall script can't find the bits it needs to remove from an existing file ... you are going to need to clean up your install I'm afraid.
Damn...
Can you suggest an efficient way of doing this? I'm not really even sure of all the files that get edited. |
lasterax
Stay Frosty.
5
|
Posted - 2014.03.21 23:20:00 -
[237] - Quote
Migrated my forum to get on the same server as comms. Thins have gone well except for when running the API check, I get the following error:
Quote:You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 File: /var/www/forums/Sources/TEA.php Line: 2492
Checking the error log I also get the following:
8: Undefined property: TEA::$lastid
Something I missed doing the move?
--Rax |
Zenith Gravit
LionGate Enterprises Care Factor
38
|
Posted - 2014.03.22 13:17:00 -
[238] - Quote
I got my dirty install mostly cleaned up, but the user's profile page still has some extra fields and I'm just not sure what needs to be removed to clean it up. The Status, Main Matched Rules, Characters, ID from API page, and Verification Code from API Page fields are all duplicated once. I'm just trying to figure out how to clean that up.
Screen shot ----> http://i.imgur.com/0nHoabh.png |
Shin Chogan
Blueprint Haus Get Off My Lawn
57
|
Posted - 2014.03.22 13:31:00 -
[239] - Quote
Zenith Gravit wrote:I got my dirty install mostly cleaned up, but the user's profile page still has some extra fields and I'm just not sure what needs to be removed to clean it up. The Status, Main Matched Rules, Characters, ID from API page, and Verification Code from API Page fields are all duplicated once. I'm just trying to figure out how to clean that up. Screen shot ----> http://i.imgur.com/0nHoabh.png
Its supposed to be like that. There is always an unfilled section so you can add a 2nd or 3rd or xth api key. |
Jen Moriarty
Love for You Stealth Wear Inc.
41
|
Posted - 2014.03.22 14:29:00 -
[240] - Quote
Is there a debug mode to run this code in? As I said, I'm experiencing a problem described here https://forums.eveonline.com/default.aspx?g=posts&m=3969052#post3969052 and I want to be able to debug it by putting some printing statements in the called functions and seeing their results. |
|
|
|
|
Pages: 1 2 3 4 5 6 7 [8] 9 10 11 12 13 14 15 16 .. 16 :: one page |
First page | Previous page | Next page | Last page |