Pages: 1 2 [3] 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 30 40 .. 42 :: one page |
|
Author |
Thread Statistics | Show CCP posts - 9 post(s) |
Pete Butcher
Kiss My Shiny Metal Ass
217
|
Posted - 2014.08.27 20:52:00 -
[61] - Quote
Dread Nanana wrote:I've just looked at the source code, and let me tell you, it looks pretty good. It's mostly readable and easy to understand, which is more than I can say for some projects. If there is anything to improve,
- Generally, I would not indent namespace that encapsulates entire file. You end up with entire file having unnecessary margin.
- Missing copyright statement - there is license, but it should say "Copyright YEAR name"
- 3rd party stuff may belong in subdirectory. It's also missing AUTHORS file it's referring to.
- In my opinion, you kind of overdid the && semantics. Copy overhead of many of the structures is no significantly greater than move.
- overuse of auto results in many warnings - comparing signed and unsigned
- overuse of lambdas, especially in EvernusApplication.cpp - many of the lambdas almost look like copy/paste?
- No unit tests, but then this is just a hobby project.
As I said, mostly minor issues. I've also fixed compilation with GCC for you. It's all related to lambdas (I tihnk clang is wrong to compile it in the first place) The patch is at, http://paste.debian.net/117900/
Warning: much technobabble.
Thanks for your suggestions/observations. There's room for improvement, especially in the copyright/legal part and in time all will be straighten up. I would like to address some points:
4. I am in Scott Meyers' camp - I believe in explicitly stated intentions about move operations (clear passing of ownership) and the inherent optimizations in move semantics. I know that some types are copied really fast (and in case of trivial types - that's what move-assignment and move-construction decays to), but nevertheless, for clarity sake, all sink parameters should be passed by &&, in my opinion. Contrary to what Herb Sutter advocates (use pass-by-value for sinks), but I find his arguments not strong enough and see inconsistencies it introduces. 5. I have zero warnings both in Visual Studio and clang. Can you point me to the specific lines, so I can correct them? 6. Unfortunately, some were copy-pasted as things got rushed. But I plan on cleaning it up.
Thanks for the gcc patch. Strangely, I see that gcc seems to treat signals as a dependent names in generic lambdas, thus requires this->. Well, that's gcc and their buggy standards compliance. There's a bigger issue with it - they have (or at least had in 4.8.1) a bug in binding references using uniform initialization. It actually results from a bug in the C++11 standard - http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1288 and it causes binding to actually create a prvalue first to be bound. That's why I'm a little skeptic about gcc build - it may silently make some references actually bind to copies.
EDIT: Also please excuse some inconsistencies in parts of the code - I have to navigate around incomplete VS standard compliance and bugs in their CTP compiler. http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Dread Nanana
Action Super Dupper Test Corp
29
|
Posted - 2014.08.28 04:06:00 -
[62] - Quote
Pete Butcher wrote:[quote=Dread Nanana] Thanks for your suggestions/observations. There's room for improvement, especially in the copyright/legal part and in time all will be straighten up. I would like to address some points: 4. I am in Scott Meyers' camp - I believe in explicitly stated intentions about move operations (clear passing of ownership) and the inherent optimizations in move semantics. I know that some types are copied really fast (and in case of trivial types - that's what move-assignment and move-construction decays to), but nevertheless, for clarity sake, all sink parameters should be passed by &&, in my opinion. Contrary to what Herb Sutter advocates (use pass-by-value for sinks), but I find his arguments not strong enough and see inconsistencies it introduces. 5. I have zero warnings both in Visual Studio and clang. Can you point me to the specific lines, so I can correct them? 6. Unfortunately, some were copy-pasted as things got rushed. But I plan on cleaning it up. Thanks for the gcc patch. Strangely, I see that gcc seems to treat signals as a dependent names in generic lambdas, thus requires this->. Well, that's gcc and their buggy standards compliance. There's a bigger issue with it - they have (or at least had in 4.8.1) a bug in binding references using uniform initialization. It actually results from a bug in the C++11 standard - http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1288 and it causes binding to actually create a prvalue first to be bound. That's why I'm a little skeptic about gcc build - it may silently make some references actually bind to copies. EDIT: Also please excuse some inconsistencies in parts of the code - I have to navigate around incomplete VS standard compliance and bugs in their CTP compiler.
No issues with move operators, aside I'm in the camp of "more LOC == more chance of bugs". Worse bugs I came across tend to end up as "copy paste" or otherwise similar code doing same thing, so when changing one code you have to remember to change the other as otherwise things fall apart.
If you compile with GCC (like 4.9), you'll see a whole load of warnings about unsigned with signed comparison. All of them tend to be a result of,
for (auto i=0; i[<]vector.size(); ++I) ...
here, i becomes signed int since 0 is signed. Either s/auto/size_t/ or use 0u literal.
I know copy/paste is result of rushing, that's fine. Your code looks rather good. Even parts of Qt library tend to look worse. But if you make changes, best changes are always the ones that keep all functionality, but remove code complexity. This I tend to define as either LOC or indentations.
PS. Yes, techno-babble above. BEWARE And I had to insert those ugly square brackets around less than sign above or EVE forums would barf on me for "inserting HTML"
|
Pete Butcher
Kiss My Shiny Metal Ass
217
|
Posted - 2014.08.28 04:21:00 -
[63] - Quote
Dread Nanana wrote:Pete Butcher wrote:[quote=Dread Nanana] Thanks for your suggestions/observations. There's room for improvement, especially in the copyright/legal part and in time all will be straighten up. I would like to address some points: 4. I am in Scott Meyers' camp - I believe in explicitly stated intentions about move operations (clear passing of ownership) and the inherent optimizations in move semantics. I know that some types are copied really fast (and in case of trivial types - that's what move-assignment and move-construction decays to), but nevertheless, for clarity sake, all sink parameters should be passed by &&, in my opinion. Contrary to what Herb Sutter advocates (use pass-by-value for sinks), but I find his arguments not strong enough and see inconsistencies it introduces. 5. I have zero warnings both in Visual Studio and clang. Can you point me to the specific lines, so I can correct them? 6. Unfortunately, some were copy-pasted as things got rushed. But I plan on cleaning it up. Thanks for the gcc patch. Strangely, I see that gcc seems to treat signals as a dependent names in generic lambdas, thus requires this->. Well, that's gcc and their buggy standards compliance. There's a bigger issue with it - they have (or at least had in 4.8.1) a bug in binding references using uniform initialization. It actually results from a bug in the C++11 standard - http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1288 and it causes binding to actually create a prvalue first to be bound. That's why I'm a little skeptic about gcc build - it may silently make some references actually bind to copies. EDIT: Also please excuse some inconsistencies in parts of the code - I have to navigate around incomplete VS standard compliance and bugs in their CTP compiler. No issues with move operators, aside I'm in the camp of "more LOC == more chance of bugs". Worse bugs I came across tend to end up as "copy paste" or otherwise similar code doing same thing, so when changing one code you have to remember to change the other as otherwise things fall apart. If you compile with GCC (like 4.9), you'll see a whole load of warnings about unsigned with signed comparison. All of them tend to be a result of, for (auto i=0; i[<]vector.size(); ++I) ... here, i becomes signed int since 0 is signed. Either s/auto/size_t/ or use 0u literal. I know copy/paste is result of rushing, that's fine. Your code looks rather good. Even parts of Qt library tend to look worse. But if you make changes, best changes are always the ones that keep all functionality, but remove code complexity. This I tend to define as either LOC or indentations. PS. Yes, techno-babble above. BEWARE And I had to insert those ugly square brackets around less than sign above or EVE forums would barf on me for "inserting HTML"
So gcc is more "literal" when it comes to type deduction in these cases. Interesting. I will change it. http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Syd Echerie
Fort Hill Cartel
0
|
Posted - 2014.08.30 02:44:00 -
[64] - Quote
So, the corp orders as char orders isn't working perfectly for me, but I think that's because I already had corp orders imported, and so the 'owner' is a little borked. I'm thinking it'll be all cool if I can delete the orders -- But I'd prefer not to repaste all my APIs back in. What should I delete so Evernus doesn't have any orders listed? |
Pete Butcher
Kiss My Shiny Metal Ass
217
|
Posted - 2014.08.30 07:30:00 -
[65] - Quote
Syd Echerie wrote:So, the corp orders as char orders isn't working perfectly for me, but I think that's because I already had corp orders imported, and so the 'owner' is a little borked. I'm thinking it'll be all cool if I can delete the orders -- But I'd prefer not to repaste all my APIs back in. What should I delete so Evernus doesn't have any orders listed?
Such direct deletion isn't possible from the application yet (I'm adding a ton of new actions to context menus for the next version and it should be there). If you want, you can play around with it's database. It's called main.db and it's located in the system application data folder. You can use http://sqlitestudio.pl/?act=download for that. http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Tee Kay Solus
Poseidon Industries And Trading
44
|
Posted - 2014.08.30 07:44:00 -
[66] - Quote
Any chances in the nearest future of making it available for 32Bit systems ? "Be polite, be professional, but have a plan to kill everybody you meet."
- Maj. Gen. James Mattis
|
Pete Butcher
Kiss My Shiny Metal Ass
217
|
Posted - 2014.08.30 07:48:00 -
[67] - Quote
Tee Kay Solus wrote:Any chances in the nearest future of making it available for 32Bit systems ?
Actually there was a 32 bit version, but it only ran on 64bit systems (oh, the irony!). I'm going for a second attempt for 1.11 and we'll see. It takes much longer with no direct access to a 32bit system, but it will be there hopefully next week. http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Tee Kay Solus
Poseidon Industries And Trading
44
|
Posted - 2014.08.30 07:50:00 -
[68] - Quote
That`d be fantastic! I`ll be eagerly looking forward to it. "Be polite, be professional, but have a plan to kill everybody you meet."
- Maj. Gen. James Mattis
|
Syd Echerie
Fort Hill Cartel
0
|
Posted - 2014.08.30 23:36:00 -
[69] - Quote
The corp-as-character orders isn't working really.
The in game export button on 'My Orders' doesn't work with Evernus' 'File Import' on the 'Character orders' tab.
Exporting from 'Corporate Orders' in-game and 'File Import' on the 'Corporation orders' in-app does get the orders into Evernus. But, it is not reading the 'Issued by'. It's treating all of the corps' orders as owned by whatever character is selected in the Evernus character drop-down menu when the 'File import' is clicked.
I've tried to work around that as best I can, the 'limit to station' checkbox on the IGB scanner does help.
However, when an order is completed, and therefore no longer being exported, I have to do multiple exports and imports in order to make Evernus stop listing the order, since the 'Owner' is dependent on the dropdown.
|
Pete Butcher
Kiss My Shiny Metal Ass
217
|
Posted - 2014.08.31 07:38:00 -
[70] - Quote
Syd Echerie wrote:The corp-as-character orders isn't working really.
The in game export button on 'My Orders' doesn't work with Evernus' 'File Import' on the 'Character orders' tab.
Exporting from 'Corporate Orders' in-game and 'File Import' on the 'Corporation orders' in-app does get the orders into Evernus. But, it is not reading the 'Issued by'. It's treating all of the corps' orders as owned by whatever character is selected in the Evernus character drop-down menu when the 'File import' is clicked.
I've tried to work around that as best I can, the 'limit to station' checkbox on the IGB scanner does help.
However, when an order is completed, and therefore no longer being exported, I have to do multiple exports and imports in order to make Evernus stop listing the order, since the 'Owner' is dependent on the dropdown.
Ok, I did some tests and got these results:
- Character log import from logs works without any problems.
- Character log import doesn't import corporation orders - that is by design, so no error here.
- Corporation log import doesn't import character orders - by design.
- Corporation log import imports orders, but indeed the owner is replaced by current character.
The owner will be fixed in the next version. API import doesn't have this problem. http://evernus.com - the ultimate multiplatform-áEVE trade tool |
|
Pete Butcher
Kiss My Shiny Metal Ass
217
|
Posted - 2014.09.01 17:53:00 -
[71] - Quote
New version is here:
- [new] all tables now save their hidden and moved columns
- [new] favorite items in IGB
- [new] overbid/undercut orders in IGB
- [new] below min. margin orders in IGB
- [new] copy suggested price in context menus
- [new] contract timer warning in character tab
- [new] corporation wallet status in statistics
- [new] option to combine wallet journal/transactions with characterGÇÖs (Price settings in Preferences)
- [new] deleting orders from order tables
- [new] market browser quick link in context menus
- [new] auto-import prices when market scan completes
- [new] possibility to open market in EVE from a context menu in Evernus
- [fixed] incorrect corporation order owner when importing from logs
- [fixed] ETA calculation now displays correct values
- [fixed] character removal
- [fixed] margin tool opening only once from IGB
- [fixed] importing HUGE asset lists from the Web
- [fixed] unit size number formating in market browser
- [changed] leading and trailing whitespace is now removed from key vCode GÇô no more manual trimming
- [changed] not showing market orders for order history
- [changed] batch database storing now happens in a separate thread (no more freezing)
- [changed] new user agent when polling API
http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Pete Butcher
Kiss My Shiny Metal Ass
217
|
Posted - 2014.09.02 17:45:00 -
[72] - Quote
Hotfix 1.12 is available:
- [new] option to display packaged ship sizes
- [fixed] partial corporation orders in IGB
- [fixed] sorting by ETA
- [fixed] crash when trying to communicate with non-existent IGB connection
As Evernus has real-time bi-directional communication with IGB, anyone has any ideas for some additional features which could use that? http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Pete Butcher
Kiss My Shiny Metal Ass
220
|
Posted - 2014.09.03 20:04:00 -
[73] - Quote
An experimental Windows 32bit version is available: http://evernus.com/download/
Was tested on Windows 7 and seems to work fine, but for the moment is considered experimental, just in case. http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Tee Kay Solus
Poseidon Industries And Trading
44
|
Posted - 2014.09.04 09:42:00 -
[74] - Quote
Have just downloaded the 32bit version and will be testing it on Vista. I`ll report any problems here should i come across them. "Be polite, be professional, but have a plan to kill everybody you meet."
- Maj. Gen. James Mattis
|
Pete Butcher
Kiss My Shiny Metal Ass
220
|
Posted - 2014.09.04 16:14:00 -
[75] - Quote
Anyone interested in trying out experimental Dropbox synchronization? https://bitbucket.org/krojew/evernus/downloads/evernus-setup-1.12-64bit-dropbox.exe (back up your database just in case)
Sync settings are in the preferences dialog and tools menu. Limited to 100 users during tests. http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Grymtrade Wulf
Antex Innovations
17
|
Posted - 2014.09.04 21:06:00 -
[76] - Quote
Feature Request:
Charater Orders API import, option to switch to file only or pick source. For some reason API clears orders, have to reimport wallet order export. I am a card carrying copper-plated *****, with a capital B.-á Deal with it. |
Pete Butcher
Kiss My Shiny Metal Ass
220
|
Posted - 2014.09.05 04:25:00 -
[77] - Quote
Grymtrade Wulf wrote:Feature Request:
Charater Orders API import, option to switch to file only or pick source. For some reason API clears orders, have to reimport wallet order export.
That's most likely due to re-importing cached data, which updates all the delta information. I will add a default import source and an option to ignore cached data import. http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Grymtrade Wulf
Antex Innovations
17
|
Posted - 2014.09.05 06:15:00 -
[78] - Quote
Pete Butcher wrote: That's most likely due to re-importing cached data, which updates all the delta information. I will add a default import source and an option to ignore cached data import.
Thank you
I am a card carrying copper-plated *****, with a capital B.-á Deal with it. |
Grymtrade Wulf
Antex Innovations
17
|
Posted - 2014.09.09 09:54:00 -
[79] - Quote
Request:
Ability to clear market browser history for items. I've got a couple of items that won't update price and imports from logs and cache at an incorrect value. It seems to be trying to match a price located at a different station in the same system than the one I'm doing my trading in. Price was pulled on 9/6/14 - but won't fall out. Just the ability to clear all price data to re-import would help clear these issues. Pulling price data from logs and cache from today 9/9/14 does not clear this invalid data point.
Request:
Check to see if another copy of evernus is running before opening a new instance. I am a card carrying copper-plated *****, with a capital B.-á Deal with it. |
Pete Butcher
Kiss My Shiny Metal Ass
225
|
Posted - 2014.09.09 13:38:00 -
[80] - Quote
Grymtrade Wulf wrote:Request:
Ability to clear market browser history for items. I've got a couple of items that won't update price and imports from logs and cache at an incorrect value. It seems to be trying to match a price located at a different station in the same system than the one I'm doing my trading in. Price was pulled on 9/6/14 - but won't fall out. Just the ability to clear all price data to re-import would help clear these issues. Pulling price data from logs and cache from today 9/9/14 does not clear this invalid data point.
(Deleting the evernus db in appdata/local/evernus.com and re-importing everything cleared this invalid price point - but I'd sure love not to have to put all the api data in, and lose order histories etc)
Request:
Check to see if another copy of evernus is running before opening a new instance.
Done and done. A new version will be out soon. http://evernus.com - the ultimate multiplatform-áEVE trade tool |
|
Pete Butcher
Kiss My Shiny Metal Ass
227
|
Posted - 2014.09.09 18:33:00 -
[81] - Quote
And a new version arrived with a few new features:
- [new] option to ignore re-importing already cached data (defaults to false for upgrading users; true for new installations)
- [new] option to specify default market log import source (API/logs)
- [new] GÇ£price difference, %GÇ¥ column for sell orders GÇô price difference divided by custom cost (you can hide/move it via context menu)
- [new] option to auto-copy non-overbid prices from price helper popup (Price preferences; defaults to false)
- [new] transaction view info panel GÇô total quantity, size, income, costs, balance and profit
- [new] total income, cost and margin info for sell orders
- [new] ability to input custom prices into the Margin Tool you can experiment with any data you wish
- [new] ability to remove stored text filters via right-click menu on text drop-down list
- [new] restoring main window after closing the Margin Tool
- [new] date range quick filters (Today, Past day, This week, Past week, This month, Past month)
- [new] ability to hide main tabs
- [new] allowing only one instance of Evernus to be launched
- [new] ability to clear market browser data (competition prices)
- [fixed] corporation market orders sometimes not importing from API
- [fixed] auto-costs from corporation orders
- [fixed] table column state sometimes not restoring
- [changed] corporation market order value snapshots are taken separately, but combined with characterGÇÖs in statistics (fixes strange value oscillations)
- [changed] column showed/hidden/moved state is now stored individually for each table
- [changed] IGB now removes duplicate item types
- [changed] toggling GÇ£scriptGÇ¥ in market order tab now clears filter text
- [changed] floating point numbers in scriptable statistics now use fixed-point format instead of scientific
Known issue: filter text dropdown disappears on Windows when right-clicking on an item (will be fixed).
Enjoy and don't hesitate to send a small donation http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Kallie Rae
Deep Core Mining Inc. Caldari State
43
|
Posted - 2014.09.09 18:58:00 -
[82] - Quote
Nice!
Suggestion, would it be possible, on the margin tool, to add a number saying how much it would cost to buy up everything of the item one exported? |
Pete Butcher
Kiss My Shiny Metal Ass
227
|
Posted - 2014.09.09 19:28:00 -
[83] - Quote
Kallie Rae wrote:Nice!
Suggestion, would it be possible, on the margin tool, to add a number saying how much it would cost to buy up everything of the item one exported?
Edit: Also "Import from Cache" doesn't seem to always work? Or are there any tips behind it? Thinking about character orders.
By "everything" you mean all sell orders or all from the top sell order?
Cache import seems to work when I test it. Maybe eve didn't refresh the cache yet? http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Kallie Rae
Deep Core Mining Inc. Caldari State
43
|
Posted - 2014.09.09 19:43:00 -
[84] - Quote
Was thinking about all the sell orders, no idea if it's possible though. |
Pete Butcher
Kiss My Shiny Metal Ass
227
|
Posted - 2014.09.09 20:01:00 -
[85] - Quote
Kallie Rae wrote:Was thinking about all the sell orders, no idea if it's possible though.
Should be possible. I will check. http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Tsufuri Ormand
NE Procurement
3
|
Posted - 2014.09.13 08:44:00 -
[86] - Quote
I've got a problem with buy orders. I like to setup my buy orders 1 jump away from jita and use 1 jump range so I actually buy 99% of items in jita. Unless somebody places a buy order that affects my "origin" station Evernus won't mark the order as overbid. Is there any option that I am missing that can compare prices in the whole buy range and not only origin station? |
Pete Butcher
Kiss My Shiny Metal Ass
231
|
Posted - 2014.09.13 11:38:00 -
[87] - Quote
Tsufuri Ormand wrote:I've got a problem with buy orders. I like to setup my buy orders 1 jump away from jita and use 1 jump range so I actually buy 99% of items in jita. Unless somebody places a buy order that affects my "origin" station Evernus won't mark the order as overbid. Is there any option that I am missing that can compare prices in the whole buy range and not only origin station?
Also corp journal and transactions dont load.
Evernus only takes into account orders that affect yours, otherwise there would be a ton of false overbids. Corp stuff works fine for me. Did set up the correct permission? Is the type and date range filter valid? http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Wee Heavy Mangeiri
Republic University Minmatar Republic
1
|
Posted - 2014.09.13 11:38:00 -
[88] - Quote
I like the tool so far. I have one question. Is there a way to change the character you are managing without having to go to the manage character window and check/uncheck the boxes?
I am using the OSX version. |
Pete Butcher
Kiss My Shiny Metal Ass
231
|
Posted - 2014.09.13 11:40:00 -
[89] - Quote
Wee Heavy Mangeiri wrote:I like the tool so far. I have one question. Is there a way to change the character you are managing without having to go to the manage character window and check/uncheck the boxes?
I am using the OSX version.
On other systems there is a combo box with characters to the right of the menu (you can see it in the screenshots). I assumed it would also be there on OS X (as I don't have a Mac, I cannot tell). Isn't it there? http://evernus.com - the ultimate multiplatform-áEVE trade tool |
Tsufuri Ormand
NE Procurement
3
|
Posted - 2014.09.13 12:41:00 -
[90] - Quote
Pete Butcher wrote:Tsufuri Ormand wrote:I've got a problem with buy orders. I like to setup my buy orders 1 jump away from jita and use 1 jump range so I actually buy 99% of items in jita. Unless somebody places a buy order that affects my "origin" station Evernus won't mark the order as overbid. Is there any option that I am missing that can compare prices in the whole buy range and not only origin station?
Also corp journal and transactions dont load. Evernus only takes into account orders that affect yours, otherwise there would be a ton of false overbids. Corp stuff works fine for me. Did set up the correct permission? Is the type and date range filter valid?
What I mean is that I setup an order 1 jump away from jita with 1 jump range, so its active in Jita. Lets call this system - "A". If somebody in Jita places buy order higher then mine I should be able to copy new price and modify my buy order, right? But unless the order does not affect system "A" Evernus wont see it as overbid.
Corp journal and transactions - I use same API in eveHQ and it gets journal and transactions ok. Also I have one man corp so all orders are mine. |
|
|
|
|
Pages: 1 2 [3] 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 30 40 .. 42 :: one page |
First page | Previous page | Next page | Last page |