This guy says he is quitting eve I would not depend on anything this poster has.

I read this code. It certainly helped me get a good grasp on how one might approach such an application, and owing to it's simplicity, it served as a good learning tool that way.

However, personally, I wouldn't use it in a production environment. There isn't any abstraction between presentation code and server logic, so it's not terribly maintainable/customisable, and, for example, multiple redundant calls are made to mysql_connect etc when reinstantiating the database object, which sometimes happens several times per request.

Not actually sure how this works at all lol :P Perhaps a readme/guide is in order?

clean?
roflmao.

if it was clean it would not need to turn of errors (ini_set( "display_errors", 0);)
or add error suppression(@) at several spots.

Also, mixing up PHP and HTML in the same files is considered far from clean,
it at least could use a template system.

includes in the constructor of a method class? seriously? ******* up opcode caches ftw.

the prepareString of the database class does not properly sanitize users input (no addslashes and htmlspecialchars won't do), so there are sql injection vectors on this.

and isn't it just lovely how the dumpUsers.php script allows everyone to copy and run with the complete user database?


@OP: don't be scared away, lookup the things i just mentioned on the net, you might learn something

@Dragonaire: clean, rofl. idiot.

includes in the constructor of a method class? seriously? ******* up opcode caches ftw.

The HTML and PHP are seperate.. the only part that isn't is the pages that require the user to be logged in, and those pages simply call a php class to define a logged in instance.

dumpUsers.php is a test script to see how things are called from the database etc and to get an idea of the table layouts.. another reason is because there is no admin panel.

Yes the DB class does not have add slashes, but why don't you add that? its pretty simple to do. Or even better use REGEX aswel to validate.

Anyhows as for this, i guess i'll need to extend it from the db class? If not i'll check it out m8. thanks for the replies!
Thanks.

My comment on clean was two fold and I'll explain what I meant vs what Johnny May seems to think it does.
1. It's not sending a copy of your data some where else.

2. The code is nicely formated and the classes make sense.

If I'd said it was good solid code without error or bugs then you should laugh at me maybe I do think as some others have pointed out it's a good place to start but I know I would make some changes before putting it on a live server myself but

I'm glad to see someone actually put something out there so it can be peer reviewed and improved instead of the usual 'Give me X whatever and I'll make something for you'. From what I've heard from a couple people that has tried that route this code would have been an improvement over what they got.

What I would like to see happen is instead of just having a download is to have it hosted somewhere by the original author put it up on SourceForge, GitHub, or another public site like that so everyone can contribute to it more directly. I also don't remember seeing any kind of licensing like GPL etc being include with the code and that really would need to be cleared up before anyone could safely use it on their site as well.

Putting his code to public domain without any license is a totally legit move, and personally i'd allways prefer that over the viral GPL.

The best way obviously would be a BSD style license, but you don't need to include a license of code that you hand to the public domain. Otherwise every little snipped code you'd give to anyone (hello world!) would need a license.

anyone have a copy of this so i can look at it?

Database connection success!

Database connection file created!

Failed to create user table..

I have a problem running the setup/setup.php:



Did you know something about these error?

Did you create a database table and then enter the database table name in the setup window? if not thats what the error is for. If you did i will have a look at it and will update github.

So does this handle anything such as tickets or draws?? Or is this simply a wallet tracker at the moment?